fix(shell-bson-parser): do not allow arbitrary function calls on literals COMPASS-10678#784
Merged
Conversation
addaleax
approved these changes
Jun 17, 2026
Collaborator
Author
|
Whoops, my bad, should've split it in two separate ones |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are already pretty strict about allowed function calls during parse, this patch makes the logic a bit stricter. I can't think of a case where we'd want to allow these cases for any of our purposes, but tell me if we should allowlist some methods here
See COMPASS-10678 for some extra context