Fix #155: honest story-list pagination in MCP (no silent 20-cap)#165
Merged
Conversation
list_stories and list_ready_stories hard-clamped `limit` to 20 (`Math.min(limit ?? 20, 20)`), so an agent requesting limit=500 (the server's max) silently received 20 rows — and advancing `offset` by the requested limit skipped stories. Same class as the #148a knowledge clamp. - Honor an explicit `limit` up to the server max (500); default 20 when unspecified (keeps unprompted responses compact). - Document `default 20, max 500` in both tool schemas. - Regression test (test/story_tools.test.js) covering default / honored / clamped limits and that the old 20-cap constant is gone. MCP server 2.20.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #155.
list_stories/list_ready_storiessilently clampedlimitto 20 (Math.min(limit ?? 20, 20)), so an agent requesting up to the server's documented max (500) received only 20 rows — and a loop advancingoffsetby the requested limit silently skipped stories. Same class as the #148a knowledge-enumeration clamp.Change
limitup to the server max (500); default 20 when unspecified (keeps unprompted MCP responses compact). The server already clamps to 500 / defaults to 100.default 20, max 500in bothlist_storiesandlist_ready_storiestool schemas.test/story_tools.test.js: default → 20, explicit 50/200/500 honored, 1000 → 500, and the oldMAX_PAGE_SIZE = 20constant is gone.MCP server 2.20.1. MCP tests 45/45.