Fix regression in search results a11y hovers#320268
Open
dmitrivMS wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an accessibility regression in the Search results tree by changing how hover tooltips are managed for individual match rows, avoiding per-render hover re-registration that can interfere with assistive tech object navigation.
Changes:
- Create one managed hover per match-row template (for the match text and line number) and update its content on re-render.
- Remove element-scoped hover disposables and the corresponding
disposeElementimplementation for match rows.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/search/browser/searchResultsView.ts | Switches match-row hover lifecycle from per-render setup to per-template managed hovers updated on render, reducing hover churn and improving accessibility behavior. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
vijayupadya
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #320098