[release/13.4] Allow either required npm publish owner#17975
Open
adamint wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17975Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17975" |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the release publish pipeline’s npm ESRP validation so owners only need to match any configured “required owner” alias (rather than all), while approvers continue to require all configured required approvers. Adds an infrastructure regression test to prevent the owner/approver validation semantics from converging again.
Changes:
- Add
Assert-ContainsAnyRequiredNpmAliasand use it forNpmPublishOwnersvalidation. - Keep
Assert-ContainsRequiredNpmAliasesforNpmPublishApproversvalidation (all required approvers must be present). - Add a pipeline test to assert the intended owner-vs-approver validation split.
Show a summary per file
| File | Description |
|---|---|
| eng/pipelines/release-publish-nuget.yml | Introduces “any required owner” validation and switches the owners check to use it. |
| tests/Infrastructure.Tests/Pipelines/ReleasePublishNugetPipelineTests.cs | Adds a regression test asserting owners use “any” validation while approvers remain “all”. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
dotnet test --project tests/Infrastructure.Tests/Infrastructure.Tests.csproj --no-launch-profile -- --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"