Skip to content

feature: KeysightAgilent_33XXX.py improvements#8254

Open
fe-dor wants to merge 23 commits into
microsoft:mainfrom
fe-dor:feature/keysight_33xxx_improvments
Open

feature: KeysightAgilent_33XXX.py improvements#8254
fe-dor wants to merge 23 commits into
microsoft:mainfrom
fe-dor:feature/keysight_33xxx_improvments

Conversation

@fe-dor

@fe-dor fe-dor commented Jun 30, 2026

Copy link
Copy Markdown

Hello!

I have made a few improvements to the KeysightAgilent_33XXX.py waveform generator driver:
- Expanded the list of supported devices for the KeysightAgilent_33XXX driver
- Added implementations of SCPI commands for working with: ARB signals, edges of Pulse function, output termination,
voltage autoranging
- Created tests for new commands and update sim file

Referring to the:
- Keysight Trueform Series Operating and Service Guide -
https://www.keysight.com/us/en/assets/9018-03714/service-manuals/9018-03714.pdf
- Agilent 33210A 10 MHz Function / Arbitrary Waveform Generator User’s Guide -
https://www.keysight.com/us/en/support/33210A/33210a-waveform-and-function-generator.html
- Agilent 33250A 80 MHz Function / Arbitrary Waveform Generator -
https://www.keysight.com/us/en/support/33250A/function--arbitrary-waveform-generator-80-mhz.html

Have a nice day!

@fe-dor fe-dor requested a review from a team as a code owner June 30, 2026 14:48
@fe-dor

fe-dor commented Jun 30, 2026

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree company="RC Module"

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.04%. Comparing base (508bba4) to head (dcf9681).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8254      +/-   ##
==========================================
+ Coverage   71.02%   71.04%   +0.02%     
==========================================
  Files         301      304       +3     
  Lines       31888    31911      +23     
==========================================
+ Hits        22647    22670      +23     
  Misses       9241     9241              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant