Skip to content

Minor code coverage improvements#843

Open
skottmckay wants to merge 2 commits into
mainfrom
skottmckay/MinorCodeCoverageImprovements
Open

Minor code coverage improvements#843
skottmckay wants to merge 2 commits into
mainfrom
skottmckay/MinorCodeCoverageImprovements

Conversation

@skottmckay

Copy link
Copy Markdown
Collaborator

Fix gap in coverage for HttpDownloadFile
Avoid model remove/clash by picking model not is use by other integration test fixtures.

Avoid model remove/clash by picking model not is use by other integration test fixtures.
Copilot AI review requested due to automatic review settings June 26, 2026 05:00
@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
foundry-local Ready Ready Preview, Comment Jun 26, 2026 7:29am

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes small, test-only code-coverage improvements to the C++ SDK (sdk_v2/cpp). It adds a new real-network test for the generic HttpDownloadFile downloader (used by the WebGPU/CUDA EP bootstrappers) and hardens the existing remove/redownload integration test so it no longer races other modality fixtures by accidentally evicting a shared model.

Changes:

  • Add ReservedModels() to SharedTestEnv and use it in DISABLED_DownloadFixture to exclude all models reserved by modality fixtures (not just currently-loaded ones) when picking a model to remove/redownload.
  • Add http_download_test.cc with two DISABLED_ real-network tests (success path against the WebGPU manifest, failure path against an unresolvable host), wired into the unit test target.
  • Update run_coverage.ps1 to run DISABLED_ tests in the unit step and refresh build-prerequisite docs.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk_v2/cpp/test/sdk_api/shared_test_env.h Adds ReservedModels() returning the set of fixture-reserved model pointers regardless of load state.
sdk_v2/cpp/test/sdk_api/download_test.cc Skips the reserved set when selecting a model to remove/redownload, avoiding races with other suites.
sdk_v2/cpp/test/internal_api/http_download_test.cc New disabled-by-default network tests exercising the success and DNS-failure paths of HttpDownloadFile.
sdk_v2/cpp/test/CMakeLists.txt Registers the new test source (placed alphabetically).
sdk_v2/cpp/run_coverage.ps1 Enables --gtest_also_run_disabled_tests in the unit step and updates prerequisite docs.

Comment thread sdk_v2/cpp/test/internal_api/http_download_test.cc Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants