Minor code coverage improvements#843
Open
skottmckay wants to merge 2 commits into
Open
Conversation
Avoid model remove/clash by picking model not is use by other integration test fixtures.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes small, test-only code-coverage improvements to the C++ SDK (sdk_v2/cpp). It adds a new real-network test for the generic HttpDownloadFile downloader (used by the WebGPU/CUDA EP bootstrappers) and hardens the existing remove/redownload integration test so it no longer races other modality fixtures by accidentally evicting a shared model.
Changes:
- Add
ReservedModels()toSharedTestEnvand use it inDISABLED_DownloadFixtureto exclude all models reserved by modality fixtures (not just currently-loaded ones) when picking a model to remove/redownload. - Add
http_download_test.ccwith twoDISABLED_real-network tests (success path against the WebGPU manifest, failure path against an unresolvable host), wired into the unit test target. - Update
run_coverage.ps1to runDISABLED_tests in the unit step and refresh build-prerequisite docs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
sdk_v2/cpp/test/sdk_api/shared_test_env.h |
Adds ReservedModels() returning the set of fixture-reserved model pointers regardless of load state. |
sdk_v2/cpp/test/sdk_api/download_test.cc |
Skips the reserved set when selecting a model to remove/redownload, avoiding races with other suites. |
sdk_v2/cpp/test/internal_api/http_download_test.cc |
New disabled-by-default network tests exercising the success and DNS-failure paths of HttpDownloadFile. |
sdk_v2/cpp/test/CMakeLists.txt |
Registers the new test source (placed alphabetically). |
sdk_v2/cpp/run_coverage.ps1 |
Enables --gtest_also_run_disabled_tests in the unit step and updates prerequisite docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix gap in coverage for HttpDownloadFile
Avoid model remove/clash by picking model not is use by other integration test fixtures.