Improve diskann-disk test coverage#1193
Open
arrayka wants to merge 1 commit into
Open
Conversation
Add 18 targeted unit tests covering previously untested error paths, control flow branches, and pure functions across 7 files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
==========================================
+ Coverage 90.08% 90.15% +0.07%
==========================================
Files 487 487
Lines 92325 92613 +288
==========================================
+ Hits 83167 83492 +325
+ Misses 9158 9121 -37
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
arrayka
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR increases unit test coverage in the diskann-disk crate by adding targeted tests for previously untested branches and error paths across utilities, PQ scratch handling, sector graph reconfiguration, quantization generator validation, continuation helpers, and checkpoint record management.
Changes:
- Add unit tests for partition-count estimation edge cases (clamping, odd rounding, k_base multiplier).
- Add tests covering error-path and basic-success behavior in k-means clustering, PQScratch query validation, quant generator parameter validation, sector graph reconfiguration/defaulting, continuation processing behavior, and checkpoint invalidation.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| diskann-disk/src/utils/partition.rs | Adds tests for estimate_initial_partition_count edge cases. |
| diskann-disk/src/utils/kmeans.rs | Adds tests for successful clustering output shape and cancellation error path. |
| diskann-disk/src/storage/quant/generator.rs | Adds test for missing compressed-file validation when resuming with offset. |
| diskann-disk/src/search/provider/disk_sector_graph.rs | Adds tests for reconfigure growth/no-op and block-size defaulting. |
| diskann-disk/src/search/pq/pq_scratch.rs | Adds tests for rejecting undersized queries and accepting oversized queries. |
| diskann-disk/src/build/chunking/continuation/utils.rs | Adds tests for early stop, yield-then-continue, and error propagation (sync/async). |
| diskann-disk/src/build/chunking/checkpoint/checkpoint_record_manager_with_file.rs | Adds tests for fresh-state behavior, missing-file completion state, and invalidation semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+137
to
+141
| // Query shorter than dim should fail | ||
| let short_query: Vec<f32> = (1..dim).map(|i| i as f32).collect(); // dim-1 elements | ||
| let err = pq_scratch.set(&short_query).unwrap_err(); | ||
| assert!(err.to_string().contains("expected query of length")); | ||
| } |
Comment on lines
+630
to
+634
| let err = generator.validate_params(num_points, &storage_provider); | ||
| assert!(err.is_err()); | ||
| let err_msg = format!("{:?}", err.unwrap_err()); | ||
| assert!(err_msg.contains("expected compressed file")); | ||
|
|
Comment on lines
+209
to
+212
| if !*yielded { | ||
| *yielded = true; | ||
| ContinuationGrant::Yield(std::time::Duration::from_millis(1)) | ||
| } else { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 18 targeted unit tests to the
diskann-diskcrate covering previouslyuntested error paths, control flow branches, and pure functions.