(diversity) Refactor attribute diversity to use id trait#1186
Draft
narendatha wants to merge 1 commit into
Draft
(diversity) Refactor attribute diversity to use id trait#1186narendatha wants to merge 1 commit into
narendatha wants to merge 1 commit into
Conversation
…rait Replace the AttributeValueProvider trait with a new DiverseId trait that exposes the attribute directly from the id. DiverseNeighborQueue is now generic over I: DiverseId and stores ids directly, dropping the Arc provider field. DiverseSearchParams becomes non-generic and the Diverse search adds a DP::InternalId: DiverseId bound. Unit tests rewritten around a TestId type.
narendatha
force-pushed
the
u/narendatha/attribute_diversity_refactor
branch
from
b06180f to
d4930c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.