Fix save_path silently ignored in bftree benchmarks#1163
Closed
Copilot wants to merge 2 commits into
Closed
Conversation
The BfTreeFullPrecision and BfTreeSpherical benchmarks did not call save_with on the provider after building the index, so the save_path field in the JSON input was silently ignored. Add the save logic (mirroring the non-bftree FullPrecision benchmark) to both bftree benchmark run() methods: - diskann-benchmark/src/backend/index/bftree/full_precision.rs - diskann-benchmark/src/backend/index/bftree/spherical.rs Closes #1157
Copilot
AI
changed the title
[WIP] Fix save_path not working in graph-index-bftree
Fix save_path silently ignored in bftree benchmarks
Jun 13, 2026
Contributor
|
I'll pick this up on a new branch. In my local testing of this, there were some problems with saving the quantized tree. It looks like by upgrading to the 0.5.x versions of bftree, this might be sorted. |
Contributor
|
Closing this in favor of #1183 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
save_pathingraph-index-bftreeandgraph-index-bftree-sphericalJSON configs had no effect: bothBfTreeFullPrecisionandBfTreeSphericalbenchmark backends built the index but never persisted it.Changes
bftree/full_precision.rs— afterrun_build+ checkpoint, callsave_withon the provider whensave_pathis setbftree/spherical.rs— same, after single-insert build + checkpointBoth follow the existing pattern in the non-bftree
FullPrecisionbenchmark.BfTreeProvideralready implementsSaveWith<String>for bothNoStoreandQuantVectorProvider— it just wasn't being called.