feat: add firewall explanation#286
Open
l0wl3vel wants to merge 12 commits into
Open
Conversation
l0wl3vel
force-pushed
the
feat/firewall-explanation
branch
from
c3587e1 to
b5c304a
Compare
✅ Deploy Preview for metal-stack-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for metal-stack-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
vknabel
reviewed
Jun 11, 2026
vknabel
left a comment
vknabel
left a comment
Contributor
There was a problem hiding this comment.
Where possible try to avoid we and you. Try to document the facts and concepts :)
Signed-off-by: Benjamin Ritter <benjamin.ritter@x-cellent.com>
Co-authored-by: Valentin Knabel <dev@vknabel.com>
Co-authored-by: Valentin Knabel <dev@vknabel.com>
Co-authored-by: Valentin Knabel <dev@vknabel.com>
Signed-off-by: Benjamin Ritter <benjamin.ritter@x-cellent.com>
Signed-off-by: Benjamin Ritter <benjamin.ritter@x-cellent.com>
l0wl3vel
force-pushed
the
feat/firewall-explanation
branch
from
cfd2c45 to
630d4d7
Compare
Signed-off-by: Benjamin Ritter <benjamin.ritter@x-cellent.com>
l0wl3vel
force-pushed
the
feat/firewall-explanation
branch
from
8d610ab to
5a22d9e
Compare
Signed-off-by: Benjamin Ritter <benjamin.ritter@x-cellent.com>
l0wl3vel
force-pushed
the
feat/firewall-explanation
branch
from
5a22d9e to
f89c57b
Compare
Contributor
Author
The Gardener project handles docs the same way I think their reasoning, that active voice and conversational style increases readability, is sound. And looking at their docs they also mix active and passive. Active voice is used when talking about opinions, suggestions, calls for action, task descriptions, where clarity on who the actor is important. While they use passive when talking about facts or make statements. |
simcod
reviewed
Jun 15, 2026
simcod
left a comment
simcod
left a comment
Contributor
There was a problem hiding this comment.
The section is not appearing in the rendered output.
Signed-off-by: Benjamin Ritter <benjamin.ritter@x-cellent.com>
Signed-off-by: Benjamin Ritter <benjamin.ritter@x-cellent.com>
Signed-off-by: Benjamin Ritter <benjamin.ritter@x-cellent.com>
majst01
reviewed
Jun 15, 2026
Contributor
|
Nicely done already ! |
simcod
reviewed
Jun 15, 2026
Signed-off-by: Benjamin Ritter <benjamin.ritter@x-cellent.com>
simcod
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Benjamin Ritter benjamin.ritter@x-cellent.com
Description
add firewall explanation
Used AI-Tools ✨