Document order of ips on loopback#141
Conversation
| MountOptions: createRepeatedString(33), | ||
| }, | ||
| wantErr: true, | ||
| wantErrorMessage: `validation errors: |
There was a problem hiding this comment.
removed because order of messages is not guaranteed by protovalidate
| /** | ||
| * IPs to to attach to this machine additionally | ||
| * If none given, one ip address is acquired per network for the machine | ||
| * Order of ips is preserved on the loopback interface. |
There was a problem hiding this comment.
Maybe I do not fully understand the issue, but if this is a breaking change, this is really hard to figure out if all client implementations properly do this to see the same behavior as before?
What happens when I allocate a machine with a fixed private IP and then provide an external network along with the private network for machine creation? Will the auto-acquired IP from the external network be put before my own statically passed definition or not? How can I switch it around?
I think, normal users will not be able to understand the consequences of this comment without reading this PR (+ the entire code base to the point where the network interfaces are configured?). So, to me this feels a little sparse?
As I said, maybe I do not understand the problem, I just worry that my automations break with this when I read it. 😅
3 participants
Description
The order of additional ips matters, only the first ip is used for default routes.
Used AI-Tools ✨