feat(session): log Meraki X-Request-Id on 5xx responses (beta forward-port of #420)#425
Open
TKIPisalegacycipher wants to merge 1 commit into
Open
feat(session): log Meraki X-Request-Id on 5xx responses (beta forward-port of #420)#425TKIPisalegacycipher wants to merge 1 commit into
TKIPisalegacycipher wants to merge 1 commit into
Conversation
When a 5xx response is received, the sync and async REST sessions now log the Meraki X-Request-Id response header so users can hand it to Meraki to look up the request in server-side logs. The id is included in the per-retry warning and, once retries are exhausted, logged at error level. When the header is absent, "none" is logged in its place to aid debugging. (cherry picked from commit 6e22423)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of #420 to the
betabranch.Logs the Meraki
X-Request-Idresponse header on 5xx responses so it can be handed to Meraki for server-side log lookup. Included in the per-retry warning and, once retries are exhausted, logged at error level. When the header is absent,noneis logged in its place.Applied as a clean
git cherry-pick -xof the #420 feature commit;beta's 5xx handling was byte-identical to main's pre-#420 state.Tests: 13 X-Request-Id tests pass.
🤖 Generated with Claude Code