[MCC-1514181] Error "Unsupported field type and format" for some Stri…#47
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the Arrow→pandas conversion in the service mapper to address failures when fetching datasets that include certain string-typed columns, by changing the dtype mapping behavior during DataTable → pd.DataFrame conversion.
Changes:
- Update
resource_to_fetched_datato callto_pandas(types_mapper=pd.ArrowDtype)when decoding Arrow IPC streams. - Remove several
get_datasetsinput-validation unit tests from the paginated datasets test suite.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
dataconnect/service/mappers.py |
Changes Arrow-to-pandas conversion to use pandas Arrow-backed dtypes via types_mapper. |
tests/test_get_datasets_paginated.py |
Deletes multiple runtime input-validation tests for get_datasets pagination/UUID parameters. |
Comments suppressed due to low confidence (1)
tests/test_get_datasets_paginated.py:150
- This test file removes all input-validation test cases for
get_datasets(invalid UUID, nil UUID, invalid/non-intpageandpage_size) without adding replacement coverage. This change is unrelated to the PR’s stated goal (string type mapping) and reduces protection against accidental regressions in the public API’s runtime validation behavior.
def test_translates_transport_errors(self) -> None:
transport = _FakeTransport(error=TransportError(error_code="CONN", message="cannot connect"))
service = DefaultDataConnectService(transport)
with pytest.raises(Exception, match="cannot connect"):
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dsilaghi-mdsol
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng columns
feature/bug/enhance/refactor/tech_debt/hotfix
Error "Unsupported field type and format" for some String columns.MCC-1514181Checklist
git commit --amend --no-editcommand to reduce commit messages when making small file changes (like changing linespacing).tests/folder.doc/folder.Changes Summary
[Python Lib] Error "Unsupported field type and format" for some String columns. Fix type mapping.
Deployment Notes
In addition to IAC/code, add any notes for reviewer should know.