fix(logservice): avoid nil client deref in truncate when client creation fails#24862
Open
ck89119 wants to merge 1 commit into
Open
fix(logservice): avoid nil client deref in truncate when client creation fails#24862ck89119 wants to merge 1 commit into
ck89119 wants to merge 1 commit into
Conversation
…ion fails GetOnFly may return (nil, err) when the client factory fails to create a client (e.g. logservice.NewClient times out). truncateFromRemote only handled ErrClientPoolClosed, so on any other error it ran defer client.Putback() on a nil *wrappedClient and panicked (SIGSEGV), crashing the TN. Return on any error from GetOnFly, matching the sibling Get() path. Adds a regression test. issue matrixorigin#24861 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #24861
What this PR does / why we need it:
Handle any error returned by
GetOnFlyintruncateFromRemotebefore deferringclient.Putback(), so TN does not panic when logservice client creation fails. Add a regression test that covers the nil-client error path.