Add capabilities to ParticipantInfo#1637
Open
1egoman wants to merge 2 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: fadfe6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I made #1621, I had assumed that capabilities were being exposed in
ParticipantInfoalongsideclientProtocol, so that other participants could use this newcapabilitiesfield for detection of features which may or may not be implemented by other clients. However, it looks like the first use case of capabilities (packet trailer / frame metadata) didn't need to do this - socapabilitieswas only ever added toClientInfoso that clients could report it, and the SFU then used this metadata exclusively.So, add
capabilitiestoParticipantInfoso that it can be used as part of the data streams v2 project so that a participant can detect which of their peer participants support compression, and which do not.