feat(ui): host global dialogs moved here, mounted via shared store flags#41
Merged
Conversation
Add AboutView (route /about), BugReportDialog, LoginPromptDialog and AgreementDialog. The route-less dialogs are mounted persistently in the host shell via registerHeaderItem in install() and self-bind to shared store flags (app.bugDialogOpen / auth.authPromptOpen). SystemInfoView's build card and AboutView open the bug dialog through the flag. Adds the moved about.*/bugReport.*/agreement.* i18n keys (en+fr) and brand.png. Refs #121, #33.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to the host PR (#121). Adds AboutView (route
/about) + BugReportDialog / LoginPromptDialog / AgreementDialog (+brand.png, inlined by Vite < 4 KB).index.jsregisters/aboutand mounts BugReportDialog + LoginPromptDialog persistently viaregisterHeaderItemininstall(); each self-binds to a shared store flag (app.bugDialogOpen/auth.authPromptOpen) — no props across the host/plugin boundary. SystemInfoView build card + AboutView open the dialog via the flag. Adds the movedabout.*/bugReport.*/agreement.*keys (en+fr), merged at install().Depends on the host PR exposing the flag + rendering
headerItems— merge/deploy the host first, else the@ligoj/hostflag/render isn't there.Base
feature/vuejs→ close #121 manually after merge.Tests:
npm run test16 green +npm run buildOK.