Avoid repeated refreshes for persisted async invoices#4672
Conversation
When a used async receive offer's refreshed static invoice is persisted, advance the recorded invoice creation time. This keeps the refresh threshold anchored to the newest invoice instead of making the offer look stale on every timer tick. Add coverage that a used offer does not enqueue another ServeStaticInvoice immediately after the server confirms the refresh. Co-Authored-By: HAL 9000 This finding was discovered by Project Loupe
|
👋 Thanks for assigning @valentinewallace as a reviewer! |
|
No issues found. The PR is a correct one-line bug fix: changing The added test correctly verifies no extra No bugs, security issues, or logic errors detected. |
When a used async receive offer's refreshed static invoice is persisted, advance the recorded invoice creation time. This keeps the refresh threshold anchored to the newest invoice instead of making the offer look stale on every timer tick.
Add coverage that a used offer does not enqueue another ServeStaticInvoice immediately after the server confirms the refresh.
Co-Authored-By: HAL 9000
This finding was discovered by Project Loupe