feature: add timer context support for get_client_body_reader.#336
Merged
Conversation
Contributor
|
@zhuizhuhaomeng Would you mind adding a proper description why this is needed, develop a test for this, and to rebase this on top of latest master branch so that tests are run again? TIA |
zhuizhuhaomeng
force-pushed
the
timer-support
branch
from
f362b64 to
a689e61
Compare
sriemer
requested changes
Jun 11, 2026
sriemer
left a comment
sriemer
left a comment
Contributor
There was a problem hiding this comment.
Please provide more context here for which use cases this feature is required.
Consider reading body value in 1 byte chunks in the test to demo reading chunks of data. TIA
So is the use case here something like reading big files or video chunks?
When downloading a big file in the timer, you don't want to hold the whole file in the memory, write the file into the disk piece by piece.
zhuizhuhaomeng
force-pushed
the
timer-support
branch
from
a689e61 to
5a6b5f7
Compare
Contributor
Author
|
When downloading a big file in the timer, you don't want to hold the |
sriemer
approved these changes
Jun 16, 2026
sriemer
left a comment
sriemer
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks.
Please put reformatting in another commit next time. TIA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When downloading a big file in a timer, it is unwanted to hold the
whole file in the memory. So write the file to disk piece by piece.