Skip to content

Build with Debug configuration for iPhone simulator#116

Open
devxoul wants to merge 1 commit into
leavez:masterfrom
devxoul:configuration-debug-release
Open

Build with Debug configuration for iPhone simulator#116
devxoul wants to merge 1 commit into
leavez:masterfrom
devxoul:configuration-debug-release

Conversation

@devxoul

@devxoul devxoul commented Mar 2, 2020

Copy link
Copy Markdown

Summary

This patch makes it available to use some debug features such as RxSwift's TRACE_RESOURCES. For now, we don't have a way to set compiler flags for debug build.

  post_install do |installer|
    installer.pods_project.targets.each do |target|
      target.build_configurations.each do |config|
-       if target.name == 'RxSwift'
+       if target.name == 'RxSwift' and config.name == 'Debug'
          config.build_settings['OTHER_SWIFT_FLAGS'] ||= ['-D', 'TRACE_RESOURCES']
        end
      end
    end
  end

Note

I'm not sure if there was a background that Release configuration is necessary for iPhone simulator.

@muukii

muukii commented Dec 6, 2020

Copy link
Copy Markdown

@devxoul

Hi, I think this feature would be helpful for development.
I'm working on the maintaining branch. It's better to get this PR.

What do you think?

#137

@muukii

muukii commented Dec 6, 2020

Copy link
Copy Markdown

Plus, just in case, it might be good to add a flag to enable this feature in order to ship safely.

@innocarpe

innocarpe commented Jan 4, 2021

Copy link
Copy Markdown

@muukii, Would you merge this pr to your maintaining repo? Then we can move on our cocoapods-binary repo to yours 🙏

@muukii

muukii commented Jan 4, 2021

Copy link
Copy Markdown

Yes, I can merge it.
But should not add an option to enable this feature?
Anyway my thing should be okay adding after.

@innocarpe

innocarpe commented Jan 4, 2021

Copy link
Copy Markdown

@muukii I guess it'll be okay because there is the condition config.name == 'Debug'. I think this actually works as a kind of flag.

We've used forked repo since Mar. 2020 and there is no specific issues!

@innocarpe

Copy link
Copy Markdown

@muukii I'll be appreciated if you apply this changes in your repo ☺️

@muukii

muukii commented Jan 10, 2021

Copy link
Copy Markdown

@innocarpe
Hi, I'm sorry I don't have time to do this now.
Would you create a PR for my repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants