Skip to content

[CI] Limit Pages write permissions to deploy job #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aobolensk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[CI] Limit Pages write permissions to deploy job #839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,6 @@ on:
workflow_call:
workflow_dispatch:

permissions:
id-token: write
contents: read
pages: write

jobs:
build-doxygen-xml:
runs-on: ubuntu-26.04
Expand Down Expand Up @@ -101,6 +96,10 @@ jobs:
- build-sphinx
- build-scoreboard
runs-on: ubuntu-26.04
permissions:
id-token: write
contents: read
pages: write
Comment on lines +99 to +101

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve workflow-level read-only token defaults

Because .github/workflows/main.yml calls this reusable workflow without a permissions override, leaving this workflow with no top-level permissions makes the three build jobs inherit the repo/org default GITHUB_TOKEN permissions. In installations where Actions is still configured for read/write defaults, that includes pages: write, so the checkout/build/upload jobs retain the Pages write privilege this change is trying to confine to deploy-pages; keep a top-level read-only baseline such as contents: read and override only this deploy job for Pages/OIDC.

Useful? React with 👍 / 👎.

environment:
name: github-pages
concurrency:
Expand Down
Loading