Skip to content

expand default permissions table to use full page width#1083

Open
areychana wants to merge 2 commits into
layer5io:masterfrom
areychana:fix/default-permissions-table-width
Open

expand default permissions table to use full page width#1083
areychana wants to merge 2 commits into
layer5io:masterfrom
areychana:fix/default-permissions-table-width

Conversation

@areychana
Copy link
Copy Markdown
Contributor

Notes for Reviewers

This PR fixes #1082

The default permissions table box was constrained to ~80% of the content column width due to the tabpane shortcode rendering inside a <ul> element, which had max-width: 80% applied by the theme.

Changes i made:

  • Wrapped the tabpane shortcode in a <div class="permissions-tabpane"> to render it outside the ul constraint
  • Added CSS to expand the tabpane to full content width
  • Centered role indicator columns (✅/❌) in the Categories tab
  • Fixed the Roles tab Description column width using table-layout: fixed with a 25/75 split

Signed commits

  • Yes, I signed my commits.

Signed-off-by: areychana <93970069+areychana@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request wraps the permissions tabpane in a new <div class="permissions-tabpane"> container and adds corresponding SCSS styles to format the permissions tables. The reviewer suggests refactoring the newly added SCSS rules to leverage nesting, which improves readability and maintainability.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread assets/scss/_content_project.scss
Signed-off-by: areychana <93970069+areychana@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2026

🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-1083/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

Copy link
Copy Markdown
Member

@KatalKavya96 KatalKavya96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @areychana,

I reviewed the PR and compared it with the reported issue.
The changes look good to me:

  • The permissions tab pane is now wrapped separately so it is no longer affected by the previous list/max-width constraint
  • The table now uses the page width much better
  • The role indicator columns in the Categories tab are visually cleaner after being centred
  • The Roles tab also looks improved with the fixed table layout and better Description column width
  • The follow up SCSS nesting refactor also makes the styling cleaner and easier to maintain

I checked the preview behaviour and the table now makes much better use of the available horizontal space while keeping the content readable

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default Permissions Table: Improve use of space on the page

2 participants