ci: pin poetry version to 1.8.5 for Python 3.9 compatibility#51
Open
kinyoklion wants to merge 5 commits into
Open
ci: pin poetry version to 1.8.5 for Python 3.9 compatibility#51kinyoklion wants to merge 5 commits into
kinyoklion wants to merge 5 commits into
Conversation
The latest Poetry version has dependencies that use dataclass(slots=True), a Python 3.10+ feature. This caused CI failures on the Windows Python 3.9 matrix entry. Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
keelerm84
reviewed
Jun 8, 2026
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
|
|
||
| - name: Install poetry |
Member
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Updated to use abatilo/actions-poetry with poetry-version: "1.8.5", kept before setup-python. Pushed in d6f4437.
Switch back to abatilo/actions-poetry action per review feedback, with poetry-version pinned to 1.8.5. Kept before setup-python to avoid Python 3.9 transitive dependency issue. Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
CI failing on Python 3.9 matrix entries due to Poetry installation error.
Describe the solution you've provided
Moves
pipx install poetry==1.8.5beforeactions/setup-pythonso pipx uses the system Python (3.12) instead of the matrix Python (3.9). Poetry 1.8.5's transitive dependencies now require Python 3.10+ (dataclass(slots=True)), so installing via pipx under Python 3.9 fails withTypeError: dataclass() got an unexpected keyword argument 'slots'.Describe alternatives you've considered
Additional context
Verified: 3/3 CI passes across all Python versions (3.9–3.13) on both Linux and Windows.
Link to Devin session: https://app.devin.ai/sessions/e40ffc3296dd45648f86ac10c42b6da5
Requested by: @kinyoklion
Note
Low Risk
Workflow-only change (step order and Poetry pin); no application or runtime behavior changes.
Overview
Fixes CI failures on Python 3.9 by changing when Poetry is installed in the Linux and Windows matrix jobs.
On both jobs, the Install poetry step now runs before
actions/setup-python, and Poetry is explicitly pinned to 1.8.5. That way Poetry is installed with the runner’s default Python instead of the matrix version, avoiding install errors when the matrix is 3.9 (Poetry 1.8.5’s dependencies expect Python 3.10+). Test and lint steps are unchanged; only workflow ordering and the Poetry version pin differ.Reviewed by Cursor Bugbot for commit d6f4437. Bugbot is set up for automated code reviews on this repo. Configure here.