Skip to content

Add DeviceKit-style group arrays and installation docs#8

Open
kudit wants to merge 3 commits into
mainfrom
devicekit-groups-install-docs
Open

Add DeviceKit-style group arrays and installation docs#8
kudit wants to merge 3 commits into
mainfrom
devicekit-groups-install-docs

Conversation

@kudit

@kudit kudit commented Jun 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds Sources/DeviceKitGroups.swift with public DeviceKit-style group arrays such as allPhones, allPads, allWatches, and derived capability groups.
  • Uses existing model lists and capability metadata instead of hard-coded generated enum cases so groups stay current as new models are added.
  • Adds INSTALLATION.md with SPM, manual installation, CocoaPods status, and Carthage status.
  • Adds AUDIT-2026-06-28.md documenting current coverage for iPhone 17/Air/17e, M5/M4 iPads, and current Apple Watch models.

Notes

  • CocoaPods and Carthage are documented as not currently published/supported rather than presented as ready-to-use install paths.
  • I did not add simulator group arrays because kudit/Device does not model simulators as separate enum cases the way DeviceKit does.

Testing

  • Not run; connector changes only.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 52ca7ca02e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

static var allProDevices: [Device] { all.filter { $0.has(.pro) } }

/// All devices marked as mini.
static var allMiniDevices: [Device] { all.filter { $0.has(.mini) } }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restrict mini group to iPad minis

For DeviceKit migration compatibility, allMiniDevices should not be every device carrying the generic .mini capability. The existing DeviceKit conversion maps mini form factor as device.is(.mini) && idiom == .pad and explicitly notes that HomePod mini and iPhone mini do not count (Development/Conversions/DeviceKitConversion.swift:542); this implementation also includes iPhone 12/13 mini, HomePod mini, and Mac mini, so callers porting iPad-mini-specific layout checks will start matching unrelated products.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant