fix(apiserver): return 400 instead of 500 for invalid resourceVersion in API Request

[Jay-0331]

What type of PR is this?

/kind bug

What this PR does / why we need it:

The apiserver was returning HTTP 500 (InternalError) when a client supplied an invalid resourceVersion in list/watch requests. An invalid resourceVersion is a client input error, not a server fault, so it should surface as HTTP 400 (BadRequest). This PR maps resourceVersion parse failures to StatusBadRequest, allowing clients to distinguish malformed requests from genuine server errors and avoid spurious retries against the apiserver.

Which issue(s) this PR is related to:

Fixes #139485

Special notes for your reviewer:

The change is scoped to the error mapping path for resourceVersion parsing; existing valid-input behavior is unchanged. Please confirm the new status code does not regress any client retry/backoff logic that may have been (incorrectly) keying off the 500 response.

Does this PR introduce a user-facing change?

kube-apiserver now returns HTTP 400 (BadRequest) instead of HTTP 500 (InternalError) when a list or watch request specifies an invalid `resourceVersion`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

N/A

[k8s-ci-robot]

Welcome @Jay-0331!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

Hi @Jay-0331. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jay-0331
Once this PR has been reviewed and has the lgtm label, please assign liggitt for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apiserver/pkg/storage/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment