Support standard vmstat output without -a flag#1
Open
nikfot wants to merge 3 commits into
Open
Conversation
Auto-detect vmstat column headers from the log file instead of hardcoding the column order. This adds support for standard vmstat output (buff/cache columns) alongside the existing vmstat -a format (inact/active columns). - Parser reads the header line and detects available columns - Timeseries.commit_raw_data() accepts a dynamic headers list - Memory plotting adapts to show buff/cache or inact/active - Add buff/cache to CLI --column choices - Add example_standard.log fixture for testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buff/cachecolumns) alongside the existingvmstat -aformat (inact/activecolumns)Changes
parser.py: Parser now reads the header line (r b swpd free buff cache ...) and detects the vmstat format automaticallytimeseries.py:commit_raw_data()accepts a dynamic headers list; addedbuff_memory_kbandcache_memory_kbattributes;COLUMN_TO_ATTRmapping extracted as module-level constantvisualizer.py: Addedbuffandcacheto--columnchoicesexamples/example_standard.logas a test fixture for standard vmstat formatTest plan
example.log(vmstat -a format) still worksexample_standard.log(standard vmstat format) correctly detects buff/cachevmstat-visualizer visualize examples/example_standard.log