entitlement: add BCD_UPDATE and QUANTITY_UPDATE subscription event types#124
Open
jutur wants to merge 1 commit into
Open
entitlement: add BCD_UPDATE and QUANTITY_UPDATE subscription event types#124jutur wants to merge 1 commit into
jutur wants to merge 1 commit into
Conversation
SubscriptionBaseTransitionType has had BCD_CHANGE and QUANTITY_CHANGE entries for some time, but the corresponding SubscriptionEventType values were never added. This means callers of Subscription.getEvents() never see BCD or quantity transitions in the returned event list. Add BCD_UPDATE and QUANTITY_UPDATE as SUBSCRIPTION_EVENT entries so that subscription event streams expose these transitions alongside PHASE, CHANGE, and other existing types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SubscriptionBaseTransitionType has had BCD_CHANGE and QUANTITY_CHANGE entries for some time, but the corresponding SubscriptionEventType values were never added. This means callers of Subscription.getEvents() never see BCD or quantity transitions in the returned event list.
Add BCD_UPDATE and QUANTITY_UPDATE as SUBSCRIPTION_EVENT entries so that subscription event streams expose these transitions alongside PHASE, CHANGE, and other existing types.