feat: add named component templates for pipeline sources, transforms, and sinks#223
Open
sakateka wants to merge 1 commit into
Open
feat: add named component templates for pipeline sources, transforms, and sinks#223sakateka wants to merge 1 commit into
sakateka wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for the great project - we use it actively. As the number of pipelines grows, managing configs becomes painful: changing a shared default (e.g. a sink) means editing every pipeline.
I explored a templating approach - not sure it’s the best possible design, but I don’t see a cleaner option yet. Would love your feedback.
Proposal: named component templates on the Vector CR
Platform admins define reusable component bodies once on
Vector/VectorAggregatorviaspec.agent.componentTemplates(also available on aggregators throughVectorCommon):sources,transforms,sinks- maps of template name -> Gotext/templatebodyPipelines reference a template explicitly:
sourceTemplate/transformTemplate/sinkTemplate:{ name, params }{{ .paramName }}with strict policy missing key => errortype: …) or templated - both together is rejectedinputsfrom the pipeline override whatever the template renderedExample - platform defines the sink once (batching, headers, encoding):
Each pipeline only passes what actually differs:
Change batch size, TLS, headers, or compression once on the Vector CR - all pipelines pick it up on the next reconcile. Pipelines without template refs behave unchanged.
Applied during config build for both agent and aggregator paths.
I haven’t used this code in production or on a test/staging environment yet.