binder: don't block in checkAuthorizationForServiceAsync()#7
Draft
jdcormie wants to merge 2 commits into
Draft
Conversation
This new server executor mirrors the ManagedChannelBuilder concept on the client. We'll use it to run blocking SecurityPolicy checks in a subsequent commit. For backwards compatibility, we default to using the server's executor() for this purpose, which is where blocking SecurityPolicy checks are run today. This ensures that all the same work is done on the same threads for existing servers.
A method named xyzAsync() should not block. Potentially blocking ServerSecurityPolicy work is now submit()ted to an offload Executor, just like we do on the client. One small behavior change is that the first call to every method now goes through the async path.
jdcormie
force-pushed
the
concurrent-server-auth
branch
from
35e6d0b to
778f6ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A method named xyzAsync() should not block. Potentially blocking
ServerSecurityPolicy work is now submitted to an "offload" Executor, just
like we do on the client. No functional change since by default that
offload Executor is the same one used to call
checkAuthorizationForServiceAsync() today.