Harden staged-publish workflow: fix ancestry guard, serialize releases, bound runtime#180
Draft
patocallaghan wants to merge 2 commits into
Draft
Harden staged-publish workflow: fix ancestry guard, serialize releases, bound runtime#180patocallaghan wants to merge 2 commits into
patocallaghan wants to merge 2 commits into
Conversation
…d runtime Follow-up to the merged staged-publishing workflow. Apply three fixes validated on the sibling packages' workflows: - verify: use fetch-depth: 0 and drop the manual `git fetch --depth=1`. The double-shallow checkout+fetch left the tag commit and the default branch tip with no shared local history, so the ancestry guard could only pass when the tag was exactly the branch tip (failing closed on legitimate releases). A full-depth checkout populates the remote ref with the history merge-base needs. - add a top-level concurrency group so overlapping releases serialize instead of racing for a dist-tag. - add timeout-minutes: 15 to stage-publish so a hung publish fails fast. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Follow-up to the merged staged-publishing workflow, applying three fixes validated on the sibling packages.
How?
fetch-depth: 0and drop the manualgit fetch. The double-shallow checkout+fetch left the tag commit and the default-branch tip with no shared history, somerge-base --is-ancestoronly passed when the tag was the branch tip — failing closed on legitimate releases.concurrency:so overlapping releases serialize instead of racing for a dist-tag.timeout-minutes: 15to the publish job.Generated with Claude Code