ABI: make Idris2 proofs genuinely compile + add machine-checked theorems#42
Merged
Merged
Conversation
The governance/licence-consistency check requires an SPDX-License-Identifier header on the LICENSE file and a `license` field in the manifest. The LICENSE body is MPL-2.0 text, so stamp `SPDX-License-Identifier: MPL-2.0` (matching the actual body) and set `license = "MPL-2.0"` (replacing `license-file`). Verified with standards/scripts/check-licence-consistency.sh (passes). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DF9CcCuL4YJoqs26eHsYiA
Make the repo's licensing single and consistent, matching the wokelangiser reference policy and the merged iseriser pattern: - Remove contradictory PMPL-1.0-or-later / Palimpsest self-claims from README badges/footers, QUICKSTART, RSR_OUTLINE, STATE-VISUALIZER, and machine-readable governance (META, stapeln, deny.toml allow-list, copilot/AGENTIC SPDX directives, Trust/Must LICENSE-content checks, per-project CLAUDE.md). - Encode the docs split in REUSE dep5: *.adoc/*.md/docs/** -> CC-BY-SA-4.0, everything else -> MPL-2.0. - READMEs show MPL-2.0 (code) + CC-BY-SA-4.0 (docs) badges; full texts live in LICENSES/; root LICENSE stays MPL-2.0 for GitHub's licence chip. Preserves legitimate non-self references: cargo-deny's AGPL deny-list, the "never use AGPL" estate policy, and the Contributor Covenant CoC. Verified: standards/scripts/check-licence-consistency.sh passes; no residual PMPL/Palimpsest self-claims remain. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DF9CcCuL4YJoqs26eHsYiA
The src/interface/abi ABI was scaffolded from a template and never
compiler-checked. Make it build clean under Idris2 0.7.0 with real proofs.
Types.idr:
- Replace %runElab thisPlatform stub (needed ElabReflection) with plain Linux.
- DecEq Result: replace non-compiling `decEq _ _ = No absurd` with all 56
explicit off-diagonal `No (\case Refl impossible)` cases over 8 constructors.
- createHandle: solve the auto `So (ptr /= 0)` via `choose` instead of leaving
the MkHandle nonNull proof unsolved.
- validationConsistent: was an unsound universally-quantified `So`; change to a
decided `Maybe (So ...)` via choose.
- CPtr: `Bits (ptrSize p)` does not typecheck (Bits is a class); represent a
pointer as CSize p (pointer-sized integer).
- cSizeOf/cAlignOf: drop the invalid `CInt _`/`CSize _` type-alias matches;
the aliases reduce to Bits32/Bits64 handled by concrete clauses.
- Annotate FFI format-code literals as Bits32.
Layout.idr:
- paddingFor: use Nat `minus` instead of `-` (Nat has no Neg).
- Replace alignUpCorrect (`DivideBy ... Refl` on symbolic input) with sound
decDivides + alignUpDivides.
- Concrete StructLayouts: supply erased proofs {sizeCorrect = Oh} and
{aligned = DivideBy k Refl} (40 = 5*8, 32 = 4*8).
- checkCABI: implement via decFieldsAligned (was a ?hole).
- verifyLayout: used nonexistent decSo and dropped the aligned obligation;
reimplement returning Maybe with both obligations discharged.
- offsetInBounds: was an unsound universal `So`; change to decided Maybe.
- fieldOffset: return Maybe (Nat, Field) (the `(n : Nat ** Field)` auto-bound
a stray implicit).
- Rename Vect n -> Vect k to avoid shadowing warnings.
Proofs.idr (new): machine-checked theorems —
- k9ContractCompliant, validationResultCompliant, mustRuleCompliant built
directly from per-field DivideBy witnesses (offset = k * alignment).
- okIsZero, trustFailureIsSeven (result-code encoding the FFI depends on).
- kennelIsZero, tiersOrdered (safety-tier ordering).
Build:
- Move flat files to src/interface/abi/K9iser/ABI/ so paths match namespaces.
- Add src/interface/abi/k9iser-abi.ipkg.
- Ignore Idris2 build artifacts (**/build/, *.ttc, *.ttm).
`idris2 --build k9iser-abi.ipkg` exits 0 with zero warnings and zero errors.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DF9CcCuL4YJoqs26eHsYiA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idris2 ABI proofs — genuinely compile + machine-checked theorems
Part of the family-wide ABI-proofs review. The hand-written ABI did not typecheck under Idris2 0.7.0; this makes it real and verified, following the merged iseriser reference.
Systemic fixes:
decEq _ _ = No absurd→ explicit off-diagonal cases;{auto 0 nonNull}smart constructors →choose-based;paddingFor-→minus; realdecDivides/decFieldsAlignedreplacing?fieldsAlignedProof; honestoffsetInBounds;thisPlatformde-%runElab'd; buildable nested layout + ipkg; newProofs.idrwith real theorems.Verified:
idris2 --buildclean (0/0); adversarial re-verify found nobelieve_me/postulate/holes.🤖 Generated with Claude Code
Generated by Claude Code