Skip to content

H-6657: Improve inventory carry cost attribution#8957

Open
CiaranMn wants to merge 3 commits into
mainfrom
cm/improve-carry-cost-calculations
Open

H-6657: Improve inventory carry cost attribution#8957
CiaranMn wants to merge 3 commits into
mainfrom
cm/improve-carry-cost-calculations

Conversation

@CiaranMn

@CiaranMn CiaranMn commented Jul 4, 2026

Copy link
Copy Markdown
Member

🌟 What is the purpose of this PR?

Some improvements to how inventory carry cost is calculated and attributed, mainly to account for intermediates which are (a) shared across multiple finished goods, and (b) are shipped as finished goods in their own right – to ensure that we neither double count nor fail to incorporate dwell cost for these.

Also deletes older dummy data versions.

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

⚠️ Known issues

🐾 Next steps

🛡 What tests cover this?

❓ How to test this?

  1. Checkout the branch / view the deployment
  2. Try X
  3. Confirm that Y

📹 Demo

@CiaranMn CiaranMn requested review from Copilot and vilkinsons July 4, 2026 13:33
@vercel

vercel Bot commented Jul 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment Jul 4, 2026 1:40pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored Preview Jul 4, 2026 1:40pm
petrinaut Skipped Skipped Jul 4, 2026 1:40pm

@cursor

cursor Bot commented Jul 4, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Demo seed cleanup only; risk is limited to environments or tests that still import the removed 2026-06-17.1 global supplier artifacts.

Overview
Removes the supplier-lines.json and supplier_performance.json seed payloads from supply-chain-demo/2026-06-17.1/_global/, dropping ~3.7k lines of precomputed PO-line and vendor OTIF rollup data for that older demo dataset version.

This aligns with pruning stale supply-chain dummy versions; the analysis gateway still serves _global/supplier-lines.json and supplier_performance.json from the current dataset (e.g. 2026-06-17.3), so runtime behavior depends on whether anything still pins 2026-06-17.1 as the active version.

The PR title/description also covers inventory carry-cost attribution changes in the frontend; those are not present in the diff snippet reviewed here.

Reviewed by Cursor Bugbot for commit 80d1ad4. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) type/eng > frontend Owned by the @frontend team type/eng > backend Owned by the @backend team area/apps labels Jul 4, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/apps type/eng > backend Owned by the @backend team type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants