Skip to content

chore(deps): refresh dependencies and patch DoS advisories#94

Merged
hakula139 merged 1 commit into
mainfrom
fix/deps-dos
Jun 26, 2026
Merged

chore(deps): refresh dependencies and patch DoS advisories#94
hakula139 merged 1 commit into
mainfrom
fix/deps-dos

Conversation

@hakula139

@hakula139 hakula139 commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Summary

Refresh dependencies across both ecosystems and clear the two open Dependabot DoS advisories (#7, #8).

  • Rust: cargo update (77 crates, semver-compatible) plus two direct major bumps — nix 0.30 → 0.31 and toml 0.8 → 1. Both have narrow usage (nix only killpg/Pid/Signal in bash.rs; toml only from_str deserialization), so the migrations are no-ops at the call sites.
  • Node: pnpm update --latest (cspell 10.0.1, markdownlint-cli2 0.22.1) plus pnpm overrides forcing the patched js-yaml and markdown-it.

Design decisions

  • DoS fix needs an override, not a direct bump. Both js-yaml and markdown-it reach the tree only transitively through markdownlint-cli2@0.22.1, which still pins the vulnerable versions, so overrides is the only way to force the patched releases.
  • js-yaml capped at ^4.2.0, not >=4.2.0. The latest is 5.1.0, but 5.x drops the default ESM export markdownlint-cli2 imports, which breaks pnpm lint. The advisory is patched in 4.2.0, so the 4.x line fixes the alert without breakage.
  • ratatui / crossterm / syntect left on their current majors. They are already at their newest major; only nix and toml had a clean newer major among our direct deps.

Changes

File Description
Cargo.toml Bump nix 0.30 → 0.31, toml 0.8 → 1
Cargo.lock Relock; cargo update across 77 crates
package.json cspell ^10.0.1, markdownlint-cli2 ^0.22.1, pnpm overrides for the DoS deps
pnpm-lock.yaml Relock onto patched + latest versions

Test plan

  • cargo fmt --all --check — clean
  • cargo clippy --all-targets -- -D warnings — zero warnings
  • cargo test — 2094 pass
  • pnpm lint — 48 files, 0 errors
  • pnpm spellcheck — 184 files, 0 issues
  • No js-yaml@4.1.1 / markdown-it@14.1.1 left in the lock

@hakula139 hakula139 added bug Something isn't working dependencies Pull requests that update a dependency file labels Jun 26, 2026
@hakula139 hakula139 self-assigned this Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Run cargo update (77 crates) and pnpm update --latest, and bump nix 0.30 -> 0.31 and toml 0.8 -> 1. The js-yaml and markdown-it DoS advisories are fixed via pnpm overrides since markdownlint-cli2 still pins the vulnerable versions transitively; js-yaml is held at 4.x because 5.x drops the default export it imports.
@hakula139 hakula139 changed the title fix(deps): patch js-yaml and markdown-it DoS advisories chore(deps): refresh dependencies and patch DoS advisories Jun 26, 2026
@hakula139 hakula139 merged commit 9c61fcb into main Jun 26, 2026
7 checks passed
@hakula139 hakula139 deleted the fix/deps-dos branch June 26, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant