chore(deps): refresh dependencies and patch DoS advisories#94
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Run cargo update (77 crates) and pnpm update --latest, and bump nix 0.30 -> 0.31 and toml 0.8 -> 1. The js-yaml and markdown-it DoS advisories are fixed via pnpm overrides since markdownlint-cli2 still pins the vulnerable versions transitively; js-yaml is held at 4.x because 5.x drops the default export it imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refresh dependencies across both ecosystems and clear the two open Dependabot DoS advisories (#7, #8).
cargo update(77 crates, semver-compatible) plus two direct major bumps —nix0.30 → 0.31 andtoml0.8 → 1. Both have narrow usage (nixonlykillpg/Pid/Signalinbash.rs;tomlonlyfrom_strdeserialization), so the migrations are no-ops at the call sites.pnpm update --latest(cspell 10.0.1, markdownlint-cli2 0.22.1) plus pnpmoverridesforcing the patchedjs-yamlandmarkdown-it.Design decisions
js-yamlandmarkdown-itreach the tree only transitively throughmarkdownlint-cli2@0.22.1, which still pins the vulnerable versions, sooverridesis the only way to force the patched releases.js-yamlcapped at^4.2.0, not>=4.2.0. The latest is 5.1.0, but 5.x drops thedefaultESM exportmarkdownlint-cli2imports, which breakspnpm lint. The advisory is patched in 4.2.0, so the 4.x line fixes the alert without breakage.ratatui/crossterm/syntectleft on their current majors. They are already at their newest major; onlynixandtomlhad a clean newer major among our direct deps.Changes
Cargo.tomlnix0.30 → 0.31,toml0.8 → 1Cargo.lockcargo updateacross 77 cratespackage.json^10.0.1, markdownlint-cli2^0.22.1, pnpm overrides for the DoS depspnpm-lock.yamlTest plan
cargo fmt --all --check— cleancargo clippy --all-targets -- -D warnings— zero warningscargo test— 2094 passpnpm lint— 48 files, 0 errorspnpm spellcheck— 184 files, 0 issuesjs-yaml@4.1.1/markdown-it@14.1.1left in the lock