Enforce maximum value for GlobalConfig.refresh_rate#439
Open
timmarkhuff wants to merge 6 commits into
Open
Conversation
timmarkhuff
changed the title
timmarkhuff
force-pushed
the
refresh-rate-resilience
branch
from
aa768c7 to
acd8f9f
Compare
- Change refresh_rate from float to Optional[float] with gt=0 and le=86400. Values above 86400s (1 day) are rejected at construction time; use None to disable refresh polling entirely. - Previously, values like 9999999999999 were accepted and silently caused time.sleep() to raise OverflowError in the inference-model-updater container, crashing it into CrashLoopBackOff. Co-authored-by: Cursor <cursoragent@cursor.com>
timmarkhuff
changed the title
timmarkhuff
force-pushed
the
refresh-rate-resilience
branch
from
bb85e26 to
fb33eb3
Compare
timmarkhuff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
le=86400toGlobalConfig.refresh_rate, capping the maximum value at 1 day.Values above this are now rejected at construction time with a clear
ValidationError.Notes
This PR is paired with groundlight/edge-endpoint#427, which makes the model-updater
loop more responsive to
set_configcalls. Neither PR depends on the other for correctness.