Skip to content

Invalidate TLD cache on any type of update#3123

Merged
gbrodman merged 1 commit into
google:masterfrom
gbrodman:tldInvalidation
Jun 30, 2026
Merged

Invalidate TLD cache on any type of update#3123
gbrodman merged 1 commit into
google:masterfrom
gbrodman:tldInvalidation

Conversation

@gbrodman

@gbrodman gbrodman commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

This change is Reviewable

*/
@RecursivePostPersist
@RecursivePostRemove
@RecursivePostUpdate

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much is this really accomplishing, given that it won't catch updates that occur on other pods?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not much but it's still correct

@CydeWeys CydeWeys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CydeWeys made 1 comment and resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on gbrodman).


core/src/main/java/google/registry/model/tld/Tld.java line 223 at r1 (raw file):

   * Invalidates the cache entry.
   *
   * <p>This is called automatically when the tld is saved. One should also call it when a tld is

Maybe update this comment then clarifying that it's only called automatically when the TLD is saved on the same pod, so thus will not catch most updates (as the number of pods is, what, north of a dozen now?).

@gbrodman gbrodman left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbrodman made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on CydeWeys).


core/src/main/java/google/registry/model/tld/Tld.java line 223 at r1 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

Maybe update this comment then clarifying that it's only called automatically when the TLD is saved on the same pod, so thus will not catch most updates (as the number of pods is, what, north of a dozen now?).

it was already this way, but sure

@CydeWeys CydeWeys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CydeWeys resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, all discussions resolved.

@CydeWeys CydeWeys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CydeWeys reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on gbrodman).

@CydeWeys CydeWeys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CydeWeys reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on gbrodman).

@gbrodman gbrodman added this pull request to the merge queue Jun 30, 2026
Merged via the queue into google:master with commit 67527f1 Jun 30, 2026
16 checks passed
@gbrodman gbrodman deleted the tldInvalidation branch June 30, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants