Invalidate TLD cache on any type of update#3123
Conversation
705bd1b to
78e2b88
Compare
| */ | ||
| @RecursivePostPersist | ||
| @RecursivePostRemove | ||
| @RecursivePostUpdate |
There was a problem hiding this comment.
How much is this really accomplishing, given that it won't catch updates that occur on other pods?
There was a problem hiding this comment.
not much but it's still correct
CydeWeys
left a comment
There was a problem hiding this comment.
@CydeWeys made 1 comment and resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on gbrodman).
core/src/main/java/google/registry/model/tld/Tld.java line 223 at r1 (raw file):
* Invalidates the cache entry. * * <p>This is called automatically when the tld is saved. One should also call it when a tld is
Maybe update this comment then clarifying that it's only called automatically when the TLD is saved on the same pod, so thus will not catch most updates (as the number of pods is, what, north of a dozen now?).
78e2b88 to
e01f8f8
Compare
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on CydeWeys).
core/src/main/java/google/registry/model/tld/Tld.java line 223 at r1 (raw file):
Previously, CydeWeys (Ben McIlwain) wrote…
Maybe update this comment then clarifying that it's only called automatically when the TLD is saved on the same pod, so thus will not catch most updates (as the number of pods is, what, north of a dozen now?).
it was already this way, but sure
CydeWeys
left a comment
There was a problem hiding this comment.
@CydeWeys resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, all discussions resolved.
CydeWeys
left a comment
There was a problem hiding this comment.
@CydeWeys reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
CydeWeys
left a comment
There was a problem hiding this comment.
@CydeWeys reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gbrodman).
This change is