Restore RFC schemas, prober XML, and OT&E route#3120
Merged
CydeWeys merged 1 commit intoJun 30, 2026
Conversation
CydeWeys
force-pushed
the
fix-prober-contacts-and-ote-button
branch
from
4adfba6 to
5731265
Compare
gbrodman
approved these changes
Jun 29, 2026
gbrodman
left a comment
gbrodman
left a comment
Collaborator
There was a problem hiding this comment.
@gbrodman reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on CydeWeys).
CydeWeys
force-pushed
the
fix-prober-contacts-and-ote-button
branch
from
5731265 to
8878cfc
Compare
gbrodman
approved these changes
Jun 29, 2026
gbrodman
left a comment
gbrodman
left a comment
Collaborator
There was a problem hiding this comment.
@gbrodman reviewed 3 files and all commit messages.
Reviewable status:
CydeWeys
force-pushed
the
fix-prober-contacts-and-ote-button
branch
from
8878cfc to
067a2ac
Compare
In commit 17b851d (google#2979), <element name="contact"> and related types were incorrectly removed from core/src/main/java/google/registry/xml/xsd/domain.xsd and rde-domain.xsd. Because those XSD schemas are published standards (RFC 5731 and RFC 5831), altering them caused JAXB unmarshaling to reject historical database records (HistoryEntry) containing <domain:contact> elements during OT&E status checks. Restore <element name="contact" minOccurs="0" maxOccurs="unbounded"/> to domain.xsd and rde-domain.xsd so all XSD schemas conform strictly to published EPP RFCs and historical contact elements unmarshal cleanly without throwing cvc-complex-type.2.4.a schema validation errors. Remove deprecated <domain:contact> elements from prober creation payload (prober/.../create.xml) to match current flow rules where contact associations are forbidden. Remove trailing slash from ote-status route parameter in RegistrarDetailsComponent to prevent double-slash (/ote-status//<id>) URL generation when checking OT&E status. BUG= http://b/529391412
CydeWeys
force-pushed
the
fix-prober-contacts-and-ote-button
branch
from
067a2ac to
53a5270
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore to core/src/main/java/google/registry/xml/xsd/domain.xsd (RFC 5731) and rde-domain.xsd (RFC 5831) so all XSD schemas conform strictly to published EPP RFCs. This allows OteStats to cleanly unmarshal archived HistoryEntry records during OT&E status checks without throwing cvc-complex-type.2.4.a schema validation errors on historical contact elements.
Remove deprecated domain:contact elements from prober creation payload (prober/.../create.xml) to match current flow rules where contact associations are forbidden.
Remove trailing slash from ote-status route parameter in RegistrarDetailsComponent to prevent double-slash (/ote-status//) URL generation when checking OT&E status.
BUG= http://b/529391412
This change is