fix(asgi): Gate query string and client IP behind send_default_pii#6501
fix(asgi): Gate query string and client IP behind send_default_pii#6501ericapisani wants to merge 2 commits into
Conversation
Move http.query and client.address attribute collection inside the should_send_default_pii() check so sensitive values are not captured by default. Fixes PY-2514 Fixes #6499
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 666e6fb. Configure here.
Codecov Results 📊✅ 88436 passed | ⏭️ 6022 skipped | Total: 94458 | Pass Rate: 93.62% | Execution Time: 298m 12s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2481 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.38% 89.35% -0.03%
==========================================
Files 192 192 —
Lines 23285 23286 +1
Branches 8002 8004 +2
==========================================
+ Hits 20811 20805 -6
- Misses 2474 2481 +7
- Partials 1309 1309 —Generated by Codecov Action |
|
If Warden is right about
|
Move http.query and client.address attribute collection inside the
should_send_default_pii() check so sensitive values are not captured
by default.
Fixes PY-2514
Fixes #6499