docs(dynamic sampling): Update DSC validation and reconstruction#18424
Open
elramen wants to merge 6 commits into
Open
docs(dynamic sampling): Update DSC validation and reconstruction#18424elramen wants to merge 6 commits into
elramen wants to merge 6 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
shellmayr
reviewed
Jun 16, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
elramen
changed the title
shellmayr
reviewed
Jun 16, 2026
constantinius
approved these changes
Jun 17, 2026
constantinius
left a comment
constantinius
left a comment
Contributor
There was a problem hiding this comment.
Changes make sense to me
Dav1dde
reviewed
Jun 17, 2026
| 1. **DSC originating from a project within the same organization** | ||
|
|
||
| 3. **A dynamic sampling context originating in a project of a different organization or an unknown project**: DSCs originating in different organizations or unknown projects are discarded and Relay will re-compute a DSC based on the data of the payload and scoped to the current project. The computed dynamic sampling context is then used to apply the dynamic sampling rules. | ||
| - **Transactions and spans v2**: The DSC is treated as valid and the sampling rules from the root project are applied as described in the previous section. |
Member
There was a problem hiding this comment.
We shouldn't mention internal details like spans v2 in the documentation. Maybe just spans or standalone spans.
|
|
||
| - **Transactions**: The DSC is reconstructed using event fields like `release`, `environment`, and `transaction`, and scoped to the transaction's project. If reconstruction fails, for example, due to the public key being missing, the DSC is removed and the item is guaranteed to be sampled. | ||
|
|
||
| - **Spans v2**: The spans are rejected - unless they are from the OTel integration, in which case a missing DSC is allowed and the sample rate is 100%. |
Member
There was a problem hiding this comment.
Same here, would just say spans or standalone spans.
We can also take out otel into a separate bullet point, in the implementation they are intermingled, but they don't need to be in a higher level documentation.
- **OTel**: [..]
- **Spans** [..]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Update docs to reflect actual behavior of DSC validation and reconstruction in Relay.
Fixes RELAY-258
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES