Skip to content

Added set_timeout(..) function...#38

Closed
JlnWntr wants to merge 1 commit into
getsenic:masterfrom
JlnWntr:master
Closed

Added set_timeout(..) function...#38
JlnWntr wants to merge 1 commit into
getsenic:masterfrom
JlnWntr:master

Conversation

@JlnWntr

@JlnWntr JlnWntr commented Dec 3, 2018

Copy link
Copy Markdown

so that you actually are able to timeout a discovery.

@JlnWntr JlnWntr mentioned this pull request Dec 3, 2018
Comment thread examples/discovery.py

manager = AnyDeviceManager(adapter_name='hci0')
manager.start_discovery()
manager.set_timeout(3 * 1000); # Timeout after 3 seconds

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the value of the timeout. I would however like to see this feature as a parameter to manager.start_discovery(), i.e. manager.start_discovery(timeout=3.0) with a default to None (meaning no timeout).

@JlnWntr

JlnWntr commented Mar 26, 2019

Copy link
Copy Markdown
Author

It's done: #45

@JlnWntr JlnWntr closed this Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants