Further Fixes for STAC Search by rajadain · Pull Request #2340 · geopython/pygeoapi

rajadain · 2026-05-11T21:18:42Z

Overview

Minor fixes that allow the STAC search endpoint to work correctly. This is in support of the USGS NHGF work.

Related Issue / discussion

This is a continuation of #2153.

Closes #2354
~~Closes #2355~~
Closes #2356

Additional information

Dependency policy (RFC2)

I have ensured that this PR meets RFC2 requirements

Updates to public demo

I have ensured that breaking changes to the pygeoapi master demo server have been addressed
- https://github.com/geopython/demo.pygeoapi.io/blob/master/services/pygeoapi_master/local.config.yml

Contributions and licensing

(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)

I'd like to contribute [feature X|bugfix Y|docs|something else] to pygeoapi. I confirm that my contributions to pygeoapi will be compatible with the pygeoapi license guidelines at the time of contribution
I have already previously agreed to the pygeoapi Contributions and Licensing Guidelines

tomkralidis

See change requests. It would be valuable to clarify the problems the PR attempts to address/fix (and/or feel free to create an issue). Thanks!

tomkralidis · 2026-05-12T01:14:15Z

-                for la in ['links', 'assets']:
-                    if feature.get(la) is None:
-                        feature[la] = []
+                if feature.get('links') is None:


What is the content model that this update is based on? Is properties.content.links and properties.content.assets part of STAC proper?

Yes. As can be seen in the STAC Spec:

links is a list, and assets is a dict.

tomkralidis · 2026-05-12T01:15:29Z

    LOGGER.debug('Attempting to derive temporal from GeoJSON feature')
    LOGGER.debug(feature)
-    if feature.get('time') is not None:
+    if not value.get('datetime') and feature.get('time') is not None:


Can we do if value.get('datetime') is None and feature.get('time') is not None: for readability?

Done in 72e7a7f

tomkralidis · 2026-05-12T01:16:23Z

            value['end_datetime'] = feature['time']['interval'][1]

-    if feature['properties'].get('created') is not None:
+    if not value.get('datetime') \


Can we do if value.get('datetime') is None and feature['properties'].get('created') is not None: for readability?

Done in 72e7a7f

rajadain · 2026-05-12T13:05:33Z

Thank you for taking a quick look! I'll add more context and motivation for the changes, and make the readability improvements today. 🙏

This mistakenly used double slashes in the URL which would break the output. A single slash fixes this. Closes geopython#2354

As specified in the STAC spec: https://stacspec.org/en/about/stac-spec/ assets are dicts, not lists. When missing, now they are initialized as the correct empty data structures. Closes geopython#2354

rajadain · 2026-06-05T18:28:25Z

Apologies for the long delay in getting back to this.

I created cards specifying the individual issues we need to fix: #2354, #2355, #2356. I've also marked this PR as closing those bugs. I've also added more detail to the individual commits, better explaining their relevance and motivation. And I've incorporated your keen recommendations to improve readability.

Would appreciate a second look at your convenience. Thank you!

tomkralidis · 2026-06-05T18:45:27Z

-                    if feature.get(la) is None:
-                        feature[la] = []
+                if feature.get('links') is None:
+                    feature['links'] = feature\


Thanks. I am seeing:

.get('properties', {})\ .get('content', {})\ .get('links', [])

A STAC Item indeed has links and assets, but they are at the root of the STAC item, not in an object called properties.content.

Indeed. This is quirk of the pgSTAC back-end. Please see #2355 for a more detailed explanation. I can also add a comment here pointing to that to keep the context near the code.

Also open to alternative approaches to address this discrepancy.

In this case, I would suggest removing this given it is backend specific. You can work around this by adding your own feature provider plugin which reads PgSTAC and returns items such that the STAC code in pygeoapi is reading content on the absence of a backend specific data model.

That makes perfect sense. I'm going to remove this commit from this PR and explore creating a pgSTAC back-end. Thank you!

That commit is gone, this is ready for another look at your convenience 🙏

Previously the `datetime` field was not used to initalize the temporal instant, causing it to be overridden by other approximations. This ensure that the initialization happens correctly, and the overrides only occur in cases when `datetime` is None. Closes geopython#2356

rajadain · 2026-06-09T15:40:55Z

Thanks for the thoughtful review!

tomkralidis · 2026-06-09T15:51:09Z

Thanks for the valuable contributions and fixes!

rajadain force-pushed the tt/fix-stac-api-on-starlette branch from 2d5f412 to a33a862 Compare May 11, 2026 21:25

tomkralidis requested changes May 12, 2026

View reviewed changes

tomkralidis added the STAC SpatioTemporal Asset Catalog label May 12, 2026

rajadain added 2 commits June 5, 2026 14:18

Fix STAC search endpoint reference

d055d89

This mistakenly used double slashes in the URL which would break the output. A single slash fixes this. Closes geopython#2354

Assets should be dict, not list

1ad933d

As specified in the STAC spec: https://stacspec.org/en/about/stac-spec/ assets are dicts, not lists. When missing, now they are initialized as the correct empty data structures. Closes geopython#2354

rajadain force-pushed the tt/fix-stac-api-on-starlette branch from a33a862 to 72e7a7f Compare June 5, 2026 18:24

tomkralidis reviewed Jun 5, 2026

View reviewed changes

tomkralidis mentioned this pull request Jun 5, 2026

Bug: Links and Assets not sourced correctly from pgSTAC #2355

Closed

rajadain force-pushed the tt/fix-stac-api-on-starlette branch from 72e7a7f to 0a7c3d8 Compare June 9, 2026 15:22

tomkralidis added this to the 0.24.0 milestone Jun 9, 2026

tomkralidis approved these changes Jun 9, 2026

View reviewed changes

tomkralidis merged commit b281f9b into geopython:master Jun 9, 2026
3 checks passed

Uh oh!

Conversation

rajadain commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Related Issue / discussion

Additional information

Dependency policy (RFC2)

Updates to public demo

Contributions and licensing

Uh oh!

tomkralidis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rajadain commented May 12, 2026

Uh oh!

rajadain commented Jun 5, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rajadain commented Jun 9, 2026

Uh oh!

tomkralidis commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rajadain commented May 11, 2026 •

edited

Loading