Skip to content

🎨 Palette: Enhance accessibility in Achievements component #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glsee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Enhance accessibility in Achievements component #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions registry/new-york/components/achievements.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,18 @@ export function Achievements({
className,
...props
}: AchievementsProps) {
const unlockedCount = achievements.filter((a) => !a.isLocked).length;

return (
<Card className={cn("w-full", className)} {...props}>
<CardHeader>
<div className="flex items-center justify-between">
<CardTitle>{title}</CardTitle>
<Badge variant="secondary">
{achievements.filter((a) => !a.isLocked).length} /{" "}
{achievements.length}
<Badge
variant="secondary"
aria-label={`${unlockedCount} out of ${achievements.length} achievements unlocked`}
>
{unlockedCount} / {achievements.length}
</Badge>
</div>
{description && <CardDescription>{description}</CardDescription>}
Expand Down Expand Up @@ -76,6 +80,9 @@ export function Achievements({
<div className="flex-1 space-y-1">
<div className="flex items-center justify-between gap-2">
<p className="font-medium leading-none">
<span className="sr-only">
{achievement.isLocked ? "Locked: " : "Unlocked: "}
</span>
{achievement.isSecret && achievement.isLocked
? "Secret Achievement"
: achievement.title}
Expand Down