Skip to content

Added RemoteConfig API#145

Open
Jeanmsilva89 wants to merge 1 commit into
fullstackreact:masterfrom
Jeanmsilva89:feature/config
Open

Added RemoteConfig API#145
Jeanmsilva89 wants to merge 1 commit into
fullstackreact:masterfrom
Jeanmsilva89:feature/config

Conversation

@Jeanmsilva89

Copy link
Copy Markdown

Re-added RemoteConfig feature.

@mikelambert

Copy link
Copy Markdown
Contributor

It seems configValueForKey only gets the stringValue of an item?

Before I discovered firestack, I had built out a firebase3 module myself for the remoteconfig and analytics stuff I had needed. If you're motivated to get this implemented, perhaps you'd be interested in stealing my remoteconfig code?

https://github.com/mikelambert/react-native-firebase3/blob/master/android/src/main/java/org/jall/reactnative/firebase/RNFIRRemoteConfig.java

https://github.com/mikelambert/react-native-firebase3/blob/master/ios/Firebase/RNFIRRemoteConfig.m

It definitely works in iOS, and I'm pretty sure it works in Android (my app is broken w.r.t. this right now, but I believe that's due to the recent inclusion of both rn-firestack and rn-firebase3 in my project, both trying to initialize fb under-the-hood)

@SuperBesse

Copy link
Copy Markdown

Hi,
have you an idea when this PR will be available ?

@nkashyap

Copy link
Copy Markdown

+1 for both ios & android

@chatras

chatras commented Dec 31, 2016

Copy link
Copy Markdown

When will this be available? Great work so far guys! Loving this library!

@matts2cant

Copy link
Copy Markdown

Hi ! Do you know when you plan on releasing this ?

@nkashyap

nkashyap commented Feb 5, 2017

Copy link
Copy Markdown

Here is PR for v3

Salakar#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants