Skip to content

fix(flow-php/postgresql): lower BulkInsert upsert with empty update set to ON CONFLICT DO NOTHING #2452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
norberttech merged 1 commit into from
Jun 16, 2026
Merged

fix(flow-php/postgresql): lower BulkInsert upsert with empty update set to ON CONFLICT DO NOTHING #2452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/lib/postgresql/src/Flow/PostgreSql/QueryBuilder/Insert/BulkInsert.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ public function onConflictDoUpdate(ConflictTarget $target, ?array $updateColumns
$assignments[$column] = 'EXCLUDED."' . $column . '"';
}

if ($assignments === []) {
return new self($this->table, $this->columns, $this->rowCount, $target, true, []);
}

return new self($this->table, $this->columns, $this->rowCount, $target, false, $assignments);
}

Expand Down
45 changes: 45 additions & 0 deletions src/lib/postgresql/tests/Flow/PostgreSql/Tests/Unit/QueryBuilder/Insert/BulkInsertTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,51 @@ public function test_on_conflict_do_update_with_all_non_conflict_columns(): void
);
}

public function test_on_conflict_do_update_with_all_columns_as_conflict_target_emits_do_nothing(): void
{
$query = BulkInsert::into('t', ['a', 'b'], 1)->onConflictDoUpdate(ConflictTarget::columns(['a', 'b']));

static::assertSame(
'INSERT INTO "t" ("a", "b") VALUES ($1, $2) ON CONFLICT ("a", "b") DO NOTHING',
$query->toSql(),
);
}

public function test_on_conflict_do_update_with_constraint_and_empty_update_columns_emits_do_nothing(): void
{
$query = BulkInsert::into('t', ['a', 'b'], 1)->onConflictDoUpdate(ConflictTarget::constraint('t_pkey'), []);

static::assertSame(
'INSERT INTO "t" ("a", "b") VALUES ($1, $2) ON CONFLICT ON CONSTRAINT "t_pkey" DO NOTHING',
$query->toSql(),
);
}

public function test_on_conflict_do_update_with_empty_update_columns_emits_do_nothing(): void
{
$query = BulkInsert::into('users', ['email', 'name'], 1)->onConflictDoUpdate(
ConflictTarget::columns(['email']),
[],
);

static::assertSame(
'INSERT INTO "users" ("email", "name") VALUES ($1, $2) ON CONFLICT ("email") DO NOTHING',
$query->toSql(),
);
}

public function test_on_conflict_do_update_with_subset_target_still_emits_do_update(): void
{
$query = BulkInsert::into('users', ['email', 'name'], 1)->onConflictDoUpdate(ConflictTarget::columns([
'email',
]));

static::assertSame(
'INSERT INTO "users" ("email", "name") VALUES ($1, $2) ON CONFLICT ("email") DO UPDATE SET "name" = EXCLUDED."name"',
$query->toSql(),
);
}

public function test_on_conflict_do_update_with_constraint(): void
{
$query = BulkInsert::into('users', ['email', 'name'], 1)->onConflictDoUpdate(
Expand Down
Loading