fix: Security hardening follow-ups and 0.3.0 changelog#145
Merged
Conversation
The recursive ownership pass runs as root after every deployment start, over content the container wrote, and followed symlinks. A container could plant a link in its bind mount and have any host file chowned to the container user on the next start. Links are now changed themselves and their targets left untouched. Closes #143
Alphanumeric secret characters were drawn with a modulo over the random byte, slightly favoring the first characters of the set. Each character is now drawn uniformly. Closes #144
Code Review SummaryThis PR focuses on security hardening and the 0.3.0 release preparations. It addresses a potential host file ownership vulnerability and ensures cryptographic uniformity in secret generation. 🚀 Key Improvements
💡 Minor Suggestions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups that landed after #142 was merged: