Skip to content

fix(web): WASM - After a SignOut with an active authStateChange/idTokenChange a null check would be thrown#18386

Open
MattyBoy4444 wants to merge 1 commit into
firebase:mainfrom
MattyBoy4444:main
Open

fix(web): WASM - After a SignOut with an active authStateChange/idTokenChange a null check would be thrown#18386
MattyBoy4444 wants to merge 1 commit into
firebase:mainfrom
MattyBoy4444:main

Conversation

@MattyBoy4444

@MattyBoy4444 MattyBoy4444 commented Jun 18, 2026

Copy link
Copy Markdown

Description

When WASM is being used, a SignOut with an active authStateChange/idTokenChange would throw a null check error

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@MattyBoy4444 MattyBoy4444 changed the title WASM - After a SignOut with an active authStateChange/idTokenChange a null check would be thrown fix: WASM - After a SignOut with an active authStateChange/idTokenChange a null check would be thrown Jun 18, 2026
@MattyBoy4444 MattyBoy4444 changed the title fix: WASM - After a SignOut with an active authStateChange/idTokenChange a null check would be thrown fix(web): WASM - After a SignOut with an active authStateChange/idTokenChange a null check would be thrown Jun 18, 2026
@SelaseKay

Copy link
Copy Markdown
Contributor

Hi @MattyBoy4444, thanks for the contribution! Could you also add a test covering this change? It would also be helpful to open an issue with reproducible steps and link this PR to it.

@MattyBoy4444

Copy link
Copy Markdown
Author

Testing isn't setup in firebase_auth_web. What would you expect the test to do? Its just a simple null check error fix. Please merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants