Skip to content

[INTER-2156] Clean-up tasks#107

Merged
Orkuncakilkaya merged 4 commits into
mainfrom
inter-2156-cleanup
Jun 23, 2026
Merged

[INTER-2156] Clean-up tasks#107
Orkuncakilkaya merged 4 commits into
mainfrom
inter-2156-cleanup

Conversation

@Orkuncakilkaya

Copy link
Copy Markdown
Contributor

Navigation and Routing Refactor:

  • Switched from static component rendering to Angular Router in both demo apps, enabling navigation between "Landing", "Home", and "Preloaded" pages. Updated navigation UI with a top nav bar.
  • Added a new LandingComponent as the main entry point for both demo apps, featuring navigation buttons.

Cache Management Improvements:

  • Enhanced the "Home" and "Preloaded" components in both demos to clear the cache on initialization and provided a "Clear cache" button in the UI.

Documentation:

  • Updated the README.md to clarify the distinction between the legacy and Angular 21 demo applications and added setup instructions for the new demo.

This PR Solves INTER-2156

@Orkuncakilkaya Orkuncakilkaya changed the title Inter 2156 cleanup [INTER-2156] Clean-up tasks Jun 22, 2026
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 75% 30/40
🟡 Branches 60% 3/5
🟢 Functions 83.33% 5/6
🟡 Lines 72.97% 27/37

Test suite run success

10 tests passing in 2 suites.

Report generated by 🧪jest coverage report action from ddfcdcc

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟡 All files 75 60 83.33 72.97
🔴  src 0 100 100 0
🔴   public-api.ts 0 100 100 0 5-13
🟢  src/lib 93.33 60 100 92.59
🟢   fingerprint.module.ts 100 100 100 100
🟢   fingerprint.providers.ts 100 100 100 100
🟢   fingerprint.service.ts 89.47 60 100 88.88 57,64
🟢   version.ts 100 100 100 100
🟡  src/lib/tokens 66.66 100 0 66.66
🟡   fingerprint-angular-settings-token.ts 66.66 100 0 66.66 7

TheUnderScorer
TheUnderScorer previously approved these changes Jun 22, 2026

@TheUnderScorer TheUnderScorer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one small suggestion, thanks!

Comment thread README.md Outdated
Co-authored-by: Przemysław Żydek <przemyslawzydek@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

@Orkuncakilkaya Orkuncakilkaya merged commit 616d317 into main Jun 23, 2026
7 checks passed
@Orkuncakilkaya Orkuncakilkaya deleted the inter-2156-cleanup branch June 23, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants