Add Swift scheduling exercice#1003
Merged
Merged
Conversation
35 tasks
mk-mxp
requested changes
Jun 28, 2026
mk-mxp
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for your contribution! I'm not totally pleased with the class interface, as it makes the problem look like a functional problem (no constructor args, one method to call). But we go with it when you do not want to invest more time / effort.
The introduction sounds more like "one meeting start given, many delivery dates derived" to me. Based on that, I'd suggest changing the implementation to this interface:
class SwiftScheduling
{
public function __construct(DateTime $meetingStart)
{
throw new \BadMethodCallException(sprintf('Implement the %s method', __FUNCTION__));
}
public function deliveryDate(string $description): DateTime
{
throw new \BadMethodCallException(sprintf('Implement the %s method', __FUNCTION__));
}
}You can use constructor promotion to ease implementation.
Contributor
Author
|
I hope I correctly understood your proposal :) |
mk-mxp
approved these changes
Jun 28, 2026
mk-mxp
left a comment
Contributor
There was a problem hiding this comment.
Yes, that's what I had in mind. Thanks for your effort!
Contributor
Author
|
You're welcome! thanks to you ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another exercice for validation.