format: migrate type guards from instanceof Array to Array.isArray#231
Merged
Conversation
Array.isArray is the cross-realm-safe form and was already used by the newer context guards (isPick, isGather) and isTransform. Migrate the remaining 12 sites across the type/pointer/materials/program/context guards up to match, rather than leaving inconsistent siblings. Behavior-preserving cleanup; no test changes needed.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistency follow-up (task #8), surfaced by the #212 review.
Array.isArrayis the cross-realm-safe form and was already used by thenewer context guards (
isPick,isGather) andisTransformon thetransform-context branch. This migrates the remaining 12
x instanceof Arraysites across thepackages/formattype guards(type/pointer/materials/program/context) up to match, rather than
leaving inconsistent siblings behind.
Scope note: the task originally named just
isVariables/isPick, but onmain
isPick/isGatherwere already migrated — onlyisVariableslagged. Since the rationale (cross-realm safety) applies uniformly and
the edit is identical, I swept all 12 sites in one pass.
Behavior-preserving; no test changes needed. Full suite green (983
passed), build/lint/format all clean.