FIX: Restore restartthinner printout behavior without --quiet#874
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #874 +/- ##
==========================================
- Coverage 84.53% 84.52% -0.01%
==========================================
Files 49 49
Lines 7405 7401 -4
==========================================
- Hits 6260 6256 -4
Misses 1145 1145 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| slicepresent, | ||
| ) | ||
| logger.info("-----------------------") | ||
| logger.info("Selected restarts:") |
There was a problem hiding this comment.
I am not sure there is any need for the user to see the log level and the logger name for each line. I would use print here too. Check the user experience in the terminal and choose what looks best.
There was a problem hiding this comment.
Fair enough. I have now change it to use print instead. 👍
alifbe
force-pushed
the
fix-restartthinner-printout
branch
from
a146ca4 to
9557be4
Compare
| if args.quiet: | ||
| logger.setLevel(logging.WARNING) | ||
| else: | ||
| logger.setLevel(logging.INFO) |
There was a problem hiding this comment.
There is no logging statements left in the file now, so you may remove all lines related to logger
There was a problem hiding this comment.
True, I have now updated the code accordingly.
alifbe
force-pushed
the
fix-restartthinner-printout
branch
from
9557be4 to
50336ea
Compare
| @@ -0,0 +1,5 @@ | |||
| UDQ | |||
|
|
|||
| DEFINE FU_PWRI1 WWIR A_01 i WWIR A_02 + WWIR A_03 + WWIR A_04 + WWIR A_05 + WWIR A_06 + WWIR A_07 + WWIR A_08 + WWIR A_09 + WWIR A_10 + WWIR A_11 + WWIR A_12 + WWIR A_13 + WWIR A_14 + WWIR A_15/ | |||
There was a problem hiding this comment.
Assuming this was not intended to be in the commit :)
There was a problem hiding this comment.
Yes, remnant from other test that is fixed in different PR.
alifbe
force-pushed
the
fix-restartthinner-printout
branch
from
50336ea to
5c35da6
Compare
3 participants
Closes #873