Move inventory to QuestState#2388
Merged
Merged
Conversation
Previously the inventory was stored in GlobalState, but was cleared when starting or abandoning a quest, because the only collectible items are the threads of Memory, Imagination, and Spirit that are found during quests. Move the inventory to the QuestState. Represent it as a separate resource. I anticipate that we may want a global inventory as well in future, with items moving from the QuestState to the GlobalState. But I also think it makes the code easier to read in both places.
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/inventory-in-quest/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Jun 16, 2026
manuq
left a comment
manuq
left a comment
Collaborator
There was a problem hiding this comment.
Nice cleanup. Yes it makes more sense that the current threads are part of the quest state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move inventory to QuestState
Previously the inventory was stored in GlobalState, but was cleared when
starting or abandoning a quest, because the only collectible items are
the threads of Memory, Imagination, and Spirit that are found during
quests.
Move the inventory to the QuestState. Represent it as a separate
resource. I anticipate that we may want a global inventory as well in
future, with items moving from the QuestState to the GlobalState. But I
also think it makes the code easier to read in both places.