Internal: Setup prettier and fix all lint/format issues#671
Open
rami-elementor wants to merge 3 commits into
Open
Internal: Setup prettier and fix all lint/format issues#671rami-elementor wants to merge 3 commits into
rami-elementor wants to merge 3 commits into
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR Description
1. Problem & Context
Integrate Prettier code formatter across the codebase to enforce consistent code style and reduce lint/format friction. Replaces manual eslint-based formatting with Prettier's opinionated, deterministic approach.
2. What Changed (Where)
.prettierrc, updatedpackage.json(Prettier + eslint-config-prettier + eslint-plugin-prettier), updated.eslintrc.jsto remove conflicting rules and extend Prettier configmodules/admin-home,dev/js,tests/playwright): Reformatted spacing, arrow functions, brackets, template literals, JSX attributeswebpack.config.js): Improved readability with expanded multi-line declarations3. How It Works
Prettier enforces formatting via
.prettierrcconfig (tabs, 80-char width, always arrow parens, bracket spacing). ESLint integration delegates formatting concerns to Prettier viaeslint-plugin-prettierandeslint-config-prettier(disables conflicting ESLint rules).npm run formatnow triggers Prettier instead of manual lint-fix cycles.4. Risks
Low risk—purely formatting, no logic changes. Only concern: Prettier's 80-char line width may force awkward breaks in long strings/URLs (e.g., test selectors), but this improves consistency at minor verbosity cost. Existing tests/functionality unaffected.
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how